The great layout change #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahueespinosa
force-pushed
the
nahuel/ros2
branch
2 times, most recently
from
8398a77
to
888914b
Compare
hidmic
approved these changes
Nov 17, 2022
nahueespinosa
force-pushed
the
nahuel/ros2
branch
3 times, most recently
from
7a2f43c
to
e86d73e
Compare
nahueespinosa
commented
Nov 17, 2022
hidmic
approved these changes
Nov 18, 2022
nahueespinosa
force-pushed
the
nahuel/ros2
branch
from
1f0327b
to
96c9b7c
Compare
|
@hidmic This is ready to go without |
hidmic
previously approved these changes
Nov 18, 2022
nahueespinosa
force-pushed
the
nahuel/ros2
branch
from
96c9b7c
to
d5d885f
Compare
|
New CI passing, going in! 🎉 |
Closed
nahueespinosa
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13, this patch re-organizes the repository to integrate it with ROS2 tools,
colconandament.Notes:
ament_cmake_google_benchmarkuses an older version ofgoogle benchmark, so we had to useBENCHMARK_TEMPLATEand removeMinWarmUpTimecalls.ament_cmake_clang_tidyusesclang-tidy-6.0.ament_lint_auto_find_test_dependencies()since I want to use our.clang-formatand.clang-tidysettings.