Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strong typedef for particle properties #144

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Add strong typedef for particle properties #144

merged 3 commits into from
Mar 20, 2023

Conversation

serraramiro1
Copy link
Collaborator

Fixes #136

Summary

  • Adds strong typedef helper
  • Both Cluster and Weights are unique types

@serraramiro1
Adds strongly typed numeric util, weight and cluster are strongly typed.
4b3a964 
Signed-off-by: Ramiro Serra <serraramiro@ekumenlabs.com>
@serraramiro1
Address last set of comments
74bf6d3 
Signed-off-by: Ramiro Serra <serraramiro@ekumenlabs.com>
@serraramiro1
Add new line
120e46f
@nahueespinosa nahueespinosa changed the title Ramiro/strong typedef Add strong typedef for particle properties Mar 20, 2023
nahueespinosa
nahueespinosa approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved in #137.

@serraramiro1 serraramiro1 merged commit 20232d9 into main Mar 20, 2023
@serraramiro1 serraramiro1 deleted the ramiro/strong_typedef_signed branch March 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Particle traits for built-in types are overloaded
2 participants
@serraramiro1 @nahueespinosa