Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename importance_sample method to reweight #158

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Rename importance_sample method to reweight #158

merged 1 commit into from
Apr 3, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Apr 1, 2023 •
edited
Loading

Fixes #151.

Summary

The term "importance sample" means the act of drawing samples with replacement with probabilities given by the importance factors, and that is not what this method does in code.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@nahueespinosa
Rename importance sample method to reweight
619d6f7 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added the enhancement New feature or request label Apr 1, 2023
@nahueespinosa nahueespinosa self-assigned this Apr 1, 2023
glpuga
glpuga approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nahueespinosa nahueespinosa merged commit a7b42cf into main Apr 3, 2023
@nahueespinosa nahueespinosa deleted the nahuel/rename-reweight branch April 3, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename importance_sample()
2 participants
@nahueespinosa @glpuga