Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework occupancy grids #188

Merged
merged 4 commits into from
May 20, 2023
Merged

Rework occupancy grids #188

merged 4 commits into from
May 20, 2023

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 16, 2023 •
edited by nahueespinosa
Loading

Closes #171.

Summary

This patch modularizes and deduplicates occupancy grid related code.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@hidmic
Rework occupancy grids
52620a1 
- Modularize functionality
- Deduplicate implementations

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 16, 2023 23:27
@hidmic hidmic mentioned this pull request May 16, 2023
Merged
6 tasks
@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels May 17, 2023
nahueespinosa
nahueespinosa reviewed May 17, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hidmic This is excellent!

beluga/include/beluga/sensor/data/dense_grid.hpp Show resolved Hide resolved
beluga/include/beluga/sensor/data/dense_grid.hpp Show resolved Hide resolved
beluga/include/beluga/sensor/data/linear_grid.hpp Show resolved Hide resolved
beluga/include/beluga/sensor/data/dense_grid.hpp Show resolved Hide resolved
beluga/include/beluga/sensor/data/dense_grid.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/sensor/data/occupancy_grid.hpp Show resolved Hide resolved
beluga/include/beluga/sensor/data/occupancy_grid.hpp Show resolved Hide resolved
beluga/include/beluga/sensor/data/occupancy_grid.hpp Outdated Show resolved Hide resolved
@hidmic
Address peer review comments
771ac50 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 19, 2023 23:26
@hidmic
Revert spurious clang-tidy change
d080b83 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
nahueespinosa
nahueespinosa previously approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hidmic
Please clang-tidy
c62af84 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 20, 2023 12:37
@hidmic hidmic merged commit 640c23d into main May 20, 2023
3 checks passed
@hidmic hidmic deleted the hidmic/rework-occupancy-grids branch May 20, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@hidmic hidmic

Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework occupancy grids
2 participants
@hidmic @nahueespinosa