-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance report for latest version with minor fixes to scripts #193
Conversation
d618404
to
35cf6d7
Compare
@nahueespinosa If we confirm these results, the multi threaded configuration should not be the default for normal amounts of particles. Look at the CPU usage for beluga in both cases when particle count is below 2k. Beluga (non-multithreaded) vs. AMCLBeluga (multithreaded) vs. AMCL |
7e57e3b
to
cd79676
Compare
I extended the report with results for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glpuga Awesome!
the multi threaded configuration should not be the default for normal amounts of particles
I agree!
Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR proposes chaging the default threading mode to "sequential" on the basis that while parallel has lower latency, the required increase in CPU usage makes it expensive for users not concerned about latency in the lower end of particle counts. See #193 . Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Proposed changes
beluga_benchmark
from running if not built with--symlink-install
--params-file
optional argument to theparameterized_run
script, which was cited in reports, but was missing from script.beluga_amcl
tonav2_amcl
, here: link to reportbeluga_amcl
README.mdcompare_results.py
script by adding a grid to the plots and making the axes logarithmic.Type of change
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.