Add tests for the AMCL node #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahueespinosa
force-pushed
the
nahuel/test-amcl-node
branch
5 times, most recently
from
f9d7161
to
2e2ff77
Compare
nahueespinosa
changed the title
nahueespinosa
force-pushed
the
nahuel/test-amcl-node
branch
from
0d59e14
to
3787643
Compare
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
hidmic
reviewed
May 24, 2023
There was a problem hiding this comment.
Overall LGTM for some unit testing complementing benchmarks. Nice work @nahueespinosa !
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
nahueespinosa
force-pushed
the
nahuel/test-amcl-node
branch
from
3787643
to
094d7a0
Compare
nahueespinosa
commented
May 24, 2023
|
@hidmic Thanks for the review! The comments have been addressed. |
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related to #101, this adds tests for the AMCL node up to 95% line coverage. It also fixes a couple of issues with lifecycle management and removes the read_only property for parameters that can change at runtime.
Type of change
Checklist
Additional comments
This is still work-in-progress.