Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default threading mode to the less cpu-consuming one #203

Merged
merged 2 commits into from
May 30, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented May 30, 2023

Proposed changes

This PR proposes chaging the default threading mode to "sequential" on the basis that while parallel has lower latency, the required increase in CPU usage makes it expensive for users not concerned about latency in the lower end of particle counts. See #193 .

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commmits have been signed for DCO

@glpuga glpuga requested a review from nahueespinosa May 30, 2023 00:41
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa added the enhancement New feature or request label May 30, 2023
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
@glpuga glpuga force-pushed the glpuga/change_default_threading_mode branch from 42ad4db to e92cc1f Compare May 30, 2023 14:20
@glpuga glpuga merged commit 9343f5b into main May 30, 2023
5 checks passed
@glpuga glpuga deleted the glpuga/change_default_threading_mode branch May 30, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants