Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new report after recent performance updates #208

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Jun 3, 2023

Proposed changes

Adds an updated report including the following changes from the last:

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commmits have been signed for DCO

Additional comments

Requires #207 to be merged first, to properly update the commit hash value in the report.

@glpuga glpuga requested a review from nahueespinosa June 3, 2023 23:26
@glpuga glpuga changed the title Generate new report after recent performance updates [REQUIRES #207] Generate new report after recent performance updates Jun 3, 2023
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

beluga_benchmark/docs/reports/2023-06-03/beam_params.yaml Outdated Show resolved Hide resolved
beluga_benchmark/docs/reports/2023-06-03/beam_params.yaml Outdated Show resolved Hide resolved
beluga_benchmark/docs/reports/2023-06-03/beam_params.yaml Outdated Show resolved Hide resolved
beluga_benchmark/docs/reports/2023-06-03/REPORT.md Outdated Show resolved Hide resolved
@glpuga glpuga changed the title [REQUIRES #207] Generate new report after recent performance updates Generate new report after recent performance updates Jun 4, 2023
Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
@glpuga glpuga merged commit 44e573b into main Jun 4, 2023
5 checks passed
@glpuga glpuga deleted the glpuga/june_report branch June 4, 2023 16:42
@nahueespinosa nahueespinosa added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants