Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map to odom transform calculation #212

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Fix map to odom transform calculation #212

merged 1 commit into from
Jun 11, 2023

Conversation

nahueespinosa
Copy link
Member

Proposed changes

This bug was not caught before because map to odom in our perfect_odometry bag is the identity.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commmits have been signed for DCO

@nahueespinosa
Fix map to odom transform
34a096d 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added the bug Something isn't working label Jun 10, 2023
@nahueespinosa nahueespinosa self-assigned this Jun 10, 2023
@nahueespinosa nahueespinosa marked this pull request as ready for review June 10, 2023 19:54
glpuga
glpuga approved these changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch!

@nahueespinosa nahueespinosa merged commit 34baaaf into main Jun 11, 2023
5 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/fix-map-to-odom-transform branch June 11, 2023 13:55
@nahueespinosa nahueespinosa added the cpp Related to C++ code label Jun 11, 2023
@nahueespinosa nahueespinosa mentioned this pull request Jun 12, 2023
Merged
7 tasks
nahueespinosa added a commit that referenced this pull request Jun 12, 2023
@nahueespinosa
Fix flaky transform test (#220)
068824e 
The test added in #212 turned out to be flaky. This patch reduces
the failure rate from ~20% to 0%.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

@hidmic hidmic Awaiting requested review from hidmic

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

Assignees

@nahueespinosa nahueespinosa

Labels
bug Something isn't working cpp Related to C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nahueespinosa @glpuga