Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ROS Noetic CI infrastructure #217

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Add ROS Noetic CI infrastructure #217

merged 11 commits into from
Jun 12, 2023

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Jun 12, 2023

Proposed changes

Follow-up PR after #209. This patch adds CI infrastructure to build beluga (and only beluga for now) against ROS Noetic in Ubuntu Focal.

Type of change

  • 馃悰 Bugfix (change which fixes an issue)
  • 馃殌 Feature (change which adds functionality)
  • 馃摎 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@hidmic
Add ROS Noetic CI infrastructure
aa1951d 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic mentioned this pull request Jun 12, 2023
Merged
7 tasks
@hidmic
Relocate pre-commit install in CI
6835e40 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Install pip for lint CI job
415a291 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic self-assigned this Jun 12, 2023
@hidmic
Install colcon extensions for build CI job
88793fb 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Drop ROS 2 Rolling CI jobs
908d0a1 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Install colcon mixin extension for build CI job
f00a0c0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Install git for build CI job
c586fa0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
nahueespinosa
nahueespinosa previously approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tools/run-clang-tidy.sh Show resolved Hide resolved
@hidmic
Disable gnu-zero-variadic-macro-arguments warnings
5966147 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Fix include order warning
f436f29 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Bring all config files on docker image build
d4349f1 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Upload humble CI artifacts only
e0f5378 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@nahueespinosa nahueespinosa added enhancement New feature or request ros Related to ROS infra Related to infrastructure and CI labels Jun 12, 2023
@hidmic hidmic merged commit 7ed0e5c into main Jun 12, 2023
10 checks passed
@hidmic hidmic deleted the hidmic/noetic-beluga branch June 12, 2023 11:19
nahueespinosa pushed a commit that referenced this pull request Jun 14, 2023
@hidmic
Add ROS Noetic support to beluga_amcl (#218)
034e19e 
Connected to #95. Builds on top of #217. This patch enables
`beluga_amcl` to build against both ROS 2 and ROS 1 distributions,
featuring interface parity with `nav2_amcl` and `amcl` alike.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@nahueespinosa nahueespinosa mentioned this pull request May 29, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@hidmic hidmic

Labels
enhancement New feature or request infra Related to infrastructure and CI ros Related to ROS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @nahueespinosa