Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ROS Noetic support to beluga_example #223

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Add ROS Noetic support to beluga_example #223

merged 2 commits into from
Jun 15, 2023

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Jun 14, 2023

Proposed changes

Connected to #95. Builds on top of #218. This patch enables beluga_example to build against both ROS 2 and ROS 1 distributions.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

nahueespinosa
nahueespinosa reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a minor comment!

beluga_example/bags/perfect_odometry.old.bag Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa added enhancement New feature or request ros Related to ROS labels Jun 14, 2023
Base automatically changed from hidmic/noetic-beluga_amcl to main June 14, 2023 20:52
@hidmic hidmic force-pushed the hidmic/noetic-beluga_example branch from b278bf1 to b0dee15 Compare June 15, 2023 02:54
@hidmic hidmic mentioned this pull request Jun 15, 2023
Merged
7 tasks
@hidmic
Add ROS Noetic support to beluga_example
6d5a537 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Please lint_cmake
9ca3a2a 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/noetic-beluga_example branch from de8f6d2 to 9ca3a2a Compare June 15, 2023 03:58
@hidmic
Copy link
Collaborator Author

hidmic commented Jun 15, 2023

Hmm, it failed the upload to codecov. Re-running humble CI job. Has this happened before?

@nahueespinosa
Copy link
Member

Has this happened before?

First time I see it.

@hidmic hidmic merged commit 3538b9c into main Jun 15, 2023
11 checks passed
@hidmic hidmic deleted the hidmic/noetic-beluga_example branch June 15, 2023 12:22
@hidmic hidmic mentioned this pull request Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@hidmic hidmic

Labels
enhancement New feature or request ros Related to ROS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @nahueespinosa