Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap up ROS Noetic support #225

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Wrap up ROS Noetic support #225

merged 3 commits into from
Jun 15, 2023

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Jun 15, 2023

Proposed changes

Closes #95. Depends on #223. This patch completes ROS Noetic support work.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@hidmic hidmic force-pushed the hidmic/noetic-beluga_example branch from de8f6d2 to 9ca3a2a Compare June 15, 2023 03:58
Base automatically changed from hidmic/noetic-beluga_example to main June 15, 2023 12:22
@hidmic
Ignore beluga_benchmark in ROS 1
20339a6 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Ignore beluga_system_tests in ROS 1
8a2b1eb 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Update repository level documentation
d2bd32b 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/complete-noetic-support branch from 8716ccd to d2bd32b Compare June 15, 2023 12:24
@hidmic hidmic merged commit ed7dfe3 into main Jun 15, 2023
8 checks passed
@hidmic hidmic deleted the hidmic/complete-noetic-support branch June 15, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beluga for ROS 1 Noetic
2 participants
@hidmic @nahueespinosa