Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List documentation deps in package.xml #228

Merged
merged 2 commits into from
Jun 17, 2023
Merged

List documentation deps in package.xml #228

merged 2 commits into from
Jun 17, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Jun 17, 2023 •
edited
Loading

Proposed changes

Fixes #226.

We will print a warning if doxygen is not installed and documentation dependencies can now be installed via rosdep.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa
List documentaition deps in package.xml
c7e9526 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Do not build docs if doxygen is not installed
4c8f43e 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa marked this pull request as ready for review June 17, 2023 16:54
@nahueespinosa nahueespinosa self-assigned this Jun 17, 2023
@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels Jun 17, 2023
hidmic
hidmic approved these changes Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy and so am I.

@nahueespinosa nahueespinosa merged commit 1543163 into main Jun 17, 2023
11 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/doc-depend branch June 17, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building API documentation should be disabled when Doxygen is not installed.
2 participants
@nahueespinosa @hidmic