-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor resampling policies into filter update control #233
Conversation
303b6a0
to
3a9b3f0
Compare
beluga_amcl/include/beluga_amcl/filter_update_control/filter_update_control_mixin.hpp
Show resolved
Hide resolved
beluga_amcl/include/beluga_amcl/filter_update_control/filter_update_control_mixin.hpp
Outdated
Show resolved
Hide resolved
beluga_amcl/include/beluga_amcl/filter_update_control/filter_update_control_mixin.hpp
Show resolved
Hide resolved
beluga_amcl/include/beluga_amcl/filter_update_control/filter_update_control_mixin.hpp
Outdated
Show resolved
Hide resolved
beluga_amcl/include/beluga_amcl/filter_update_control/filter_update_control_mixin.hpp
Show resolved
Hide resolved
68a6ada
to
7d15fb8
Compare
7d15fb8
to
d4f47dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
beluga_amcl/include/beluga_amcl/filter_update_control/filter_update_control_mixin.hpp
Show resolved
Hide resolved
Looks like tests migrating from |
Indeed. The format tests in the new package require to spread a long line into multiple lines, and therefore reduced the coverage as measured by the line count. |
d6a7ce2
to
be3be4e
Compare
Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
be3be4e
to
27f857b
Compare
Proposed changes
I still think the three policies (not the FilterUpdateControlMixin) can eventually go back into the main beluga library, but I don't think forcing a common abstraction on them will be meaningful.
Type of change
💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
Preliminary performance comparison with Nav2 looks now much better. Beam model, Beluga vs. Nav2 AMCL:
Likelihood model, Beluga vs. Nav2 AMCL: