Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid building docs by default #234

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Avoid building docs by default #234

merged 1 commit into from
Jun 25, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Jun 24, 2023 •
edited
Loading

Related to #226 and helps mitigate #227.

Type of change

  • 馃悰 Bugfix (change which fixes an issue)
  • 馃殌 Feature (change which adds functionality)
  • 馃摎 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa
Avoid building docs by default
8b64658 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels Jun 24, 2023
@nahueespinosa nahueespinosa self-assigned this Jun 24, 2023
glpuga
glpuga approved these changes Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nahueespinosa nahueespinosa merged commit 8f50238 into main Jun 25, 2023
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/do-not-build-docs branch June 25, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

@hidmic hidmic Awaiting requested review from hidmic

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nahueespinosa @glpuga