Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uncrustify and cpplint from pre-commit hooks #236

Merged
merged 8 commits into from
Jul 2, 2023
Merged

Remove uncrustify and cpplint from pre-commit hooks #236

merged 8 commits into from
Jul 2, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Jun 25, 2023 •
edited
Loading

Proposed changes

Connected to #132.

This patch removes uncrustify, cppcheck, and cpplint from the beluga_amcl package and replaces them with clang-format and clang-tidy. It also formats the code accordingly.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

The plan is to rebase and merge this after #233 lands.

@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels Jun 25, 2023
@nahueespinosa nahueespinosa self-assigned this Jun 25, 2023
@nahueespinosa nahueespinosa marked this pull request as ready for review June 25, 2023 17:45
@nahueespinosa nahueespinosa mentioned this pull request Jun 25, 2023
Merged
7 tasks
hidmic
hidmic approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for one comment

beluga_amcl/src/amcl_nodelet.cpp Outdated Show resolved Hide resolved
@nahueespinosa
Run clang-format and clang-tidy in beluga_amcl
9fd7ae3 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Submit clang-format changes
012dbc5 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Apply clang-tidy fixes
59734d3 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Change hook names for consistency
501a991 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Workaround for implicit bool conversion warning
55103d3 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Apply more clang-format changes
58a795c 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Apply more clang-tidy fixes
bc28f3b 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
More clang-format fixes
f7f719f 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit c608ddd into main Jul 2, 2023
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/remove-uncrustify branch July 2, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nahueespinosa @hidmic