Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ament_flake8 from pre-commit hooks #237

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Remove ament_flake8 from pre-commit hooks #237

merged 2 commits into from
Jul 3, 2023

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Connected to #132 and builds on top of #236.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels Jun 25, 2023
@nahueespinosa nahueespinosa self-assigned this Jun 25, 2023
Base automatically changed from nahuel/remove-uncrustify to main July 2, 2023 14:10
@nahueespinosa
Remove ament_flake8 and ament_pep257
b78229a 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa marked this pull request as ready for review July 2, 2023 14:12
hidmic
hidmic approved these changes Jul 3, 2023
View reviewed changes
.flake8 Outdated Show resolved Hide resolved
@nahueespinosa
Update ignore list
01552b9 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 3892d29 into main Jul 3, 2023
11 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/remove-ament-flake8 branch July 3, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@glpuga glpuga Awaiting requested review from glpuga

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nahueespinosa @hidmic @ivanpauno