Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake-format to pre-commit hooks #243

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Add cmake-format to pre-commit hooks #243

merged 4 commits into from
Jul 10, 2023

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Closes #224.

Type of change

  • 馃悰 Bugfix (change which fixes an issue)
  • 馃殌 Feature (change which adds functionality)
  • 馃摎 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels Jul 7, 2023
@nahueespinosa nahueespinosa self-assigned this Jul 7, 2023
@nahueespinosa
Add cmake-lint to pre-commit hooks
861d977 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Remove ament_lint_auto
3ae3295 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
glpuga
glpuga approved these changes Jul 9, 2023
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hidmic
hidmic approved these changes Jul 10, 2023
View reviewed changes
beluga_amcl/cmake/ament.cmake Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa changed the title Add cmake-lint to pre-commit hooks Add cmake-format to pre-commit hooks Jul 10, 2023
@nahueespinosa
Add custom function and autosort
c88191b 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
More custom function parsing
be9d169 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 090612c into main Jul 10, 2023
6 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/add-cmake-lint branch July 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@glpuga glpuga glpuga approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CMake linter to pre-commit hook
3 participants
@nahueespinosa @hidmic @glpuga