Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make particle cloud message weights represent pdf #260

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Make particle cloud message weights represent pdf #260

merged 1 commit into from
Oct 5, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Sep 24, 2023 •
edited
Loading

Proposed changes

This change makes the weights in the particle cloud message be representative of the estimated probability distribution.

Screenshot from 2023-09-23 21-22-15

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@glpuga glpuga force-pushed the glpuga/improve_particle_cloud_magnitudes branch 5 times, most recently from 3bf64f2 to bcc2f97 Compare September 24, 2023 22:02
glpuga
glpuga commented Sep 27, 2023
View reviewed changes
beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
@glpuga glpuga force-pushed the glpuga/improve_particle_cloud_magnitudes branch from bcc2f97 to 526b789 Compare October 3, 2023 00:26
@glpuga glpuga self-assigned this Oct 3, 2023
@glpuga
Make particle cloud message weights represent pdf
f9080a8 
Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
@glpuga glpuga force-pushed the glpuga/improve_particle_cloud_magnitudes branch from 526b789 to f9080a8 Compare October 3, 2023 13:14
hidmic
hidmic reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @nahueespinosa PTAL!

beluga_amcl/src/amcl_node.cpp Show resolved Hide resolved
beluga_amcl/src/amcl_node.cpp Show resolved Hide resolved
@glpuga glpuga requested review from hidmic and removed request for nahueespinosa October 5, 2023 13:07
hidmic
hidmic approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, LGTM!

@glpuga glpuga merged commit 3144527 into main Oct 5, 2023
7 checks passed
@glpuga glpuga deleted the glpuga/improve_particle_cloud_magnitudes branch October 5, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@glpuga glpuga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glpuga @hidmic