Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to compare_results.py to save data to csv instead of plotting #261

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Oct 12, 2023

Proposed changes

Add small code snippet to enable saving benchmark scripts data to a csv file instead of plotting.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Anything worth mentioning to the reviewers.

Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
@glpuga glpuga merged commit f9a37b6 into main Nov 5, 2023
7 checks passed
@glpuga glpuga deleted the glpuga/changes_for_paper branch November 5, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants