Add beluga_ros package
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
hidmic
reviewed
Dec 10, 2023
There was a problem hiding this comment.
Looks great @nahueespinosa! Left some comments here and there.
The definition is already exported by `beluga_ros`. Currently, `beluga_amcl` doesn't need to condition compile based on BELUGA_ROS_VERSION.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch creates a
beluga_rospackage in order to decouple common functionality to interface with ROS frombeluga_amcl. The goal is to reduce the boilerplate needed to create a new ROS localization package usingbeluga.Type of change
Checklist
Additional comments
More utilities and refactoring coming up in following PRs.