Rework generic data access #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahueespinosa
force-pushed
the
nahuel/cpo
branch
5 times, most recently
from
d03eb7b
to
764f9bc
Compare
This patch implements the following improvements: - TupleContainer correctly implements the range concept (it now has begin and end methods). - The `container_traits` definitions were removed. - Accesor functions `beluga::state`, `beluga::weight` and `beluga::cluster` are proper customization point objects. - The corresponding views are implemented with the above methods. - We now have unit tests for accessor functions. - Documentation was updated to reflect the changes. All of this makes the library more extensible, requiring less boilerplate to use custom types and, more importantly, CPOs fit much better with the range library design. Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
nahueespinosa
force-pushed
the
nahuel/cpo
branch
from
764f9bc
to
0954a0d
Compare
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch implements the following improvements:
container_traitsdefinitions were removed.beluga::state,beluga::weightandbeluga::clusterare proper customization point objects.All of this makes the library more extensible, requiring less boilerplate to use custom types and, more importantly, CPOs fit much better with the range library design.
Type of change
Checklist