Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is a particle? #280

Merged
merged 4 commits into from
Jan 6, 2024
Merged

What is a particle? #280

merged 4 commits into from
Jan 6, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Meta-programming magic to better define the particle concept and constraints (with tests!).

Related to #279.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Jan 5, 2024
@nahueespinosa nahueespinosa self-assigned this Jan 5, 2024
hidmic
hidmic reviewed Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Only one comment / wish.

beluga/include/beluga/primitives.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/primitives.hpp Show resolved Hide resolved
@nahueespinosa
What is a particle?
32f0ee5 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Make clang-tidy happy
7d63bdd 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Check for member variables
5db0b40 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
hidmic
hidmic approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me.

@nahueespinosa
Make customization points mutually exclusive
2048b4e 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 1e922e8 into main Jan 6, 2024
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/is-particle-type branch January 6, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@glpuga glpuga Awaiting requested review from glpuga

Assignees

@nahueespinosa nahueespinosa

Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nahueespinosa @hidmic