Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zip view and fix tuple vector traits #286

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add zip view and fix tuple vector traits #286

merged 1 commit into from
Jan 11, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Fixes ranges::range_value_t<beluga::TupleVector> returning a ranges::common_tuple instead of std::tuple.

Type of change

  • 馃悰 Bugfix (change which fixes an issue)
  • 馃殌 Feature (change which adds functionality)
  • 馃摎 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa
Add zip view and fix tuple vector traits
6b6762b 
Fixes `range_value_t` returning a `ranges::common_tuple` instead of
`std::tuple`.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa self-assigned this Jan 10, 2024
@nahueespinosa nahueespinosa added bug Something isn't working cpp Related to C++ code labels Jan 10, 2024
hidmic
hidmic approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add.

@nahueespinosa nahueespinosa merged commit 470557e into main Jan 11, 2024
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/tuple-vector-trait-consistency branch January 11, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@glpuga glpuga Awaiting requested review from glpuga

Assignees

@nahueespinosa nahueespinosa

Labels
bug Something isn't working cpp Related to C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nahueespinosa @hidmic