Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recovery probability estimator #295

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Add recovery probability estimator #295

merged 8 commits into from
Jan 25, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Related to #279.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Jan 22, 2024
@nahueespinosa nahueespinosa self-assigned this Jan 22, 2024
@nahueespinosa
Add adaptive probability estimator
fec3e38 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Add zero weight test
57ebfb7 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Rename probability estimator
c14e81d 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Check for zero in its integer form
51b6736 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Make the API consistent
ef24694 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa changed the title Add adaptive probability estimator Add recovery probability estimator Jan 25, 2024
hidmic
hidmic approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

beluga/include/beluga/algorithm/thrun_recovery_probability_estimator.hpp Outdated Show resolved Hide resolved
nahueespinosa and others added 3 commits January 25, 2024 09:28
@nahueespinosa @hidmic
Apply code review suggestion
e74faba 
Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Merge branch 'main' into nahuel/adaptive-sample
ca2b275 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Lint
25c5037 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit f138eb5 into main Jan 25, 2024
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/adaptive-sample branch January 25, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@glpuga glpuga Awaiting requested review from glpuga

Assignees

@nahueespinosa nahueespinosa

Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nahueespinosa @hidmic