Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate motion models to functional form #321

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Feb 13, 2024

Proposed changes

This patch migrates motion models to a functional form. Combined with #320, this affords:

beluga::actions::propagate(std::execution::par, motion(control_action_window << odom))

when propagating particles.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@hidmic hidmic self-assigned this Feb 13, 2024
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hidmic Love it.

beluga/include/beluga/motion/differential_drive_model.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/motion/differential_drive_model.hpp Outdated Show resolved Hide resolved
beluga_system_tests/test/test_system_new.cpp Show resolved Hide resolved
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from hidmic/circular-array to main February 14, 2024 02:45
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/functional-motion-model branch from 5582b84 to 5914270 Compare February 14, 2024 03:12
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic merged commit eeb7b37 into main Feb 14, 2024
5 checks passed
@hidmic hidmic deleted the hidmic/functional-motion-model branch February 14, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants