Relocate make_random_state() method
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This was referenced Feb 17, 2024
|
Hmm, I suspect coverage worsened because this patch removes more code than it adds (and thus it changed proportions). How do you want to go about it @nahueespinosa? |
|
@hidmic Let's go ahead and merge. I don't see anything standing out in the coverage reports. |
nahueespinosa
pushed a commit
that referenced
this pull request
Feb 18, 2024
### Proposed changes Follow-up to #322 and #324. This patch turns `LandmarkMapBoundaries` into an `Eigen::AlignedBox3d` alias. #### Type of change - [ ] 馃悰 Bugfix (change which fixes an issue) - [x] 馃殌 Feature (change which adds functionality) - [ ] 馃摎 Documentation (change which fixes or extends documentation) 馃挜 **Breaking change!** This will allow us to use `LandmarkMap` limits as constraint for `MultivariateUniformDistribution` instances. ### Checklist - [x] Lint and unit tests (if any) pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] All commits have been signed for [DCO](https://developercertificate.org/) ### Additional comments We have to update https://github.com/Ekumen-OS/beluga-demos too. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
nahueespinosa
pushed a commit
that referenced
this pull request
Feb 19, 2024
### Proposed changes Depends on #324. This patch migrates sensor models to a functional form. This affords: ```c++ beluga::actions::reweight(std::execution::par, sensor(std::move(measurement))) ``` when reweighting particles. #### Type of change - [ ] 馃悰 Bugfix (change which fixes an issue) - [x] 馃殌 Feature (change which adds functionality) - [ ] 馃摎 Documentation (change which fixes or extends documentation) ### Checklist - [x] Lint and unit tests (if any) pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] All commits have been signed for [DCO](https://developercertificate.org/) --------- Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Connected to #279. Follow-up to #322. This is a long due change, and as I was reworking sensor models I figured it was appropriate. This patch removes
make_random_state()from sensor models. As we still support mixins, it relocatesmake_random_state()to theRandomStateGeneratormixin, which now takes both state and map as template parameters.Type of change
馃挜 Breaking change! Sensor models no longer have nor require a
make_random_state()method.Checklist
Additional comments
I'm not super fond of these changes to
RandomStateGenerator, but they are not unreasonable in context and it is arguably a temporary workaround.We also have to update https://github.com/Ekumen-OS/beluga-demos to match.