Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AlignedBox3d as LandmarkMapBoundaries #326

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Use AlignedBox3d as LandmarkMapBoundaries #326

merged 2 commits into from
Feb 18, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Feb 17, 2024

Proposed changes

Follow-up to #322 and #324. This patch turns LandmarkMapBoundaries into an Eigen::AlignedBox3d alias.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! This will allow us to use LandmarkMap limits as constraint for MultivariateUniformDistribution instances.

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

We have to update https://github.com/Ekumen-OS/beluga-demos too.

@hidmic
Use AlignedBox3d as LandmarkMapBoundaries
433b37a 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic self-assigned this Feb 17, 2024
nahueespinosa
nahueespinosa approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic
Copy link
Collaborator Author

hidmic commented Feb 18, 2024

This will no longer fail CI when #324 goes in. I messed up the PR order.

@nahueespinosa nahueespinosa merged commit 78ccd6c into main Feb 18, 2024
7 of 8 checks passed
@nahueespinosa nahueespinosa deleted the hidmic/aligned-box-as-map-boundaries branch February 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @nahueespinosa