Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Beluga to Noble with Rolling #349

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 6, 2024

Proposed changes

ROS 2 Rolling Ridley has moved on from Ubuntu Jammy. This patch updates Beluga packages to follow Rolling to Ubuntu Noble.

Type of change

  • 馃悰 Bugfix (change which fixes an issue)
  • 馃殌 Feature (change which adds functionality)
  • 馃摎 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

The build is not quite fixed yet because not all our dependencies are available yet (or even build) for Rolling on Noble.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 6, 2024 21:38
@hidmic hidmic self-assigned this May 6, 2024
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Collaborator Author

hidmic commented May 7, 2024

@nahueespinosa is there a threshold we can set for codecov not to complain about 0.0x% changes in test coverage? I'd rather just fail on test coverage below 95% instead.

I'll merge, then work on that in a future follow-up PR.

@hidmic hidmic merged commit 3b6e23c into main May 7, 2024
11 of 12 checks passed
@hidmic hidmic deleted the hidmic/noble-support branch May 7, 2024 16:44
@nahueespinosa
Copy link
Member

@nahueespinosa is there a threshold we can set for codecov not to complain about 0.0x% changes in test coverage?

Yes, let me put something up later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants