Isolate Flatland dependency #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Co-authored-by: Nahuel Espinosa <nespinosa@ekumenlabs.com> Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This reverts commit b9e3615.
nahueespinosa
approved these changes
May 15, 2024
|
The lack of coverage seems spurious; I will delve into this later. But I think I have a good idea where it comes from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch separates the Flatland dependency from the usual ROS workflow, documenting the necessary steps to satisfy it when and if necessary. This should fix the recent breakage in Beluga doc jobs up in the ROS buildfarm (e.g. Hdev, Idev).
Type of change
Checklist