Add lint step to CI #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahueespinosa
force-pushed
the
nahuel/pre-commit-ci
branch
7 times, most recently
from
2c5c2b6
to
5ce348f
Compare
nahueespinosa
added
infra
nahueespinosa
force-pushed
the
nahuel/pre-commit-ci
branch
from
5ce348f
to
734809a
Compare
glpuga
previously approved these changes
Jan 5, 2023
That's a great point! I'll check with Rodri before merging. |
nahueespinosa
force-pushed
the
nahuel/pre-commit-ci
branch
from
610bb02
to
b39c310
Compare
|
Pipeline execution time was reduced to 9 minutes after removing |
glpuga
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a step to run pre-commit hooks in CI. Also, now the pipeline builds and tests
beluga_amclas well.There is a bit of a conflict between
blackandflake8regarding the preference of single or double quotes for strings in python. I opted for disabling string-normalization in black.Related to #3.