Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ament_lint_auto dependencies #370

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 17, 2024

Proposed changes

Alternative to #369. No other package besides beluga_benchmark uses ament_lint. We use pre-commit hooks instead. This patch removes the dependency altogether.

Type of change

  • 馃悰 Bugfix (change which fixes an issue)
  • 馃殌 Feature (change which adds functionality)
  • 馃摎 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 17, 2024 19:07
@hidmic hidmic self-assigned this May 17, 2024
@hidmic hidmic mentioned this pull request May 17, 2024
7 tasks
@nahueespinosa nahueespinosa merged commit d8d46a1 into main May 17, 2024
8 of 9 checks passed
@nahueespinosa nahueespinosa deleted the hidmic/remove-ament_lint-deps branch May 17, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants