Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remap /turtlebot/scan to /scan for Flatland #373

Merged
merged 2 commits into from
May 19, 2024
Merged

Remap /turtlebot/scan to /scan for Flatland #373

merged 2 commits into from
May 19, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 19, 2024

Proposed changes

Precisely what the title says. Not sure how this bug came this far along.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@hidmic
Remap /turtlebot/scan to /scan
54349e0 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 19, 2024 18:07
@hidmic hidmic self-assigned this May 19, 2024
@hidmic hidmic changed the title Remap /turtlebot/scan to /scan Remap /turtlebot/scan to /scan May 19, 2024
@hidmic hidmic changed the title Remap /turtlebot/scan to /scan Remap /turtlebot/scan to /scan for Flatland May 19, 2024
nahueespinosa
nahueespinosa approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic
Also for ROS 1
cd5fe14 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic merged commit 6b75fb5 into main May 19, 2024
9 checks passed
@hidmic hidmic deleted the hidmic/remap-flatland-scan branch May 19, 2024 22:40
@hidmic hidmic mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @nahueespinosa