Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tf broadcasting #375

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix tf broadcasting #375

merged 1 commit into from
May 19, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 19, 2024

Proposed changes

This is a massive bug that escaped our regression testing. We need performance testing in CI ASAP.

Type of change

  • 馃悰 Bugfix (change which fixes an issue)
  • 馃殌 Feature (change which adds functionality)
  • 馃摎 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 19, 2024 21:47
@hidmic hidmic self-assigned this May 19, 2024
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic merged commit 69d0731 into main May 19, 2024
9 checks passed
@hidmic hidmic deleted the hidmic/fix-tf-broadcasting branch May 19, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants