Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable beluga_amcl ROS 2 nodes' autostart #376

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 19, 2024

Proposed changes

This patch adds an autostart feature for beluga_amcl nodes to configure and activate themselves on demand, providing for systems that lack (or avoid) lifecycle management. It is also a escape hatch for Beluga to be usable in ROS 2 without explicitly providing a nav2_lifecycle_manager substitute.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 19, 2024 23:09
@hidmic hidmic self-assigned this May 19, 2024
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic merged commit bda970b into main May 20, 2024
9 checks passed
@hidmic hidmic deleted the hidmic/beluga_amcl-autostart branch May 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants