Rewrite make_from_state as a function object
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves compatibility with older GCC versions (9.3) that struggle to deduce the type of instantiated template functions when they are passed as arguments. Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change improves compatibility with older GCC versions (9.3) that struggle to deduce the type of instantiated template functions when they are passed as arguments.
Type of change
Checklist
Additional comments
Minimal examples that checks compatibility with GCC 9.3:
Before: https://godbolt.org/z/b1EzfKa75
After: https://godbolt.org/z/9eYzWhEqK