Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 32-bit hashes #386

Merged
merged 3 commits into from
May 24, 2024
Merged

Support 32-bit hashes #386

merged 3 commits into from
May 24, 2024

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented May 24, 2024 •
edited
Loading

Proposed changes

This change improves compatibility with 32-bit platforms (armhf).

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Trying to fix https://build.ros.org/job/Nbin_ufhf_uFhf__beluga__ubuntu_focal_armhf__binary/4/console.

@nahueespinosa
Support 32-bit hashes
56b817c 
This change improves compatibility with 32-bit platforms (`armhf`).

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added bug Something isn't working cpp Related to C++ code labels May 24, 2024
@nahueespinosa nahueespinosa self-assigned this May 24, 2024
glpuga
glpuga approved these changes May 24, 2024
View reviewed changes
beluga/include/beluga/algorithm/spatial_hash.hpp Outdated Show resolved Hide resolved
@nahueespinosa
Fail compilation if size_t is neither 32 nor 64
a3540e2 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa removed the bug Something isn't working label May 24, 2024
@nahueespinosa nahueespinosa force-pushed the nahuel/support-32-bit-hashes branch 2 times, most recently from f67f5b3 to 45cde01 Compare May 24, 2024 14:11
@nahueespinosa
Please clang-tidy
5a5e29b 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 5706444 into main May 24, 2024
10 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/support-32-bit-hashes branch May 24, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@glpuga glpuga glpuga approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
cpp Related to C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nahueespinosa @hidmic @glpuga