Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export AMCL as a loadable component #63

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Export AMCL as a loadable component #63

merged 1 commit into from
Jan 16, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Jan 15, 2023

  • Complete configuration in CMakeList to export the node as a component
  • Add an example launchfile to launch as a component

nahueespinosa
nahueespinosa approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nahueespinosa nahueespinosa added enhancement New feature or request ros Related to ROS labels Jan 16, 2023
@nahueespinosa nahueespinosa merged commit a3866eb into main Jan 16, 2023
@nahueespinosa nahueespinosa deleted the glpuga/amcl_node_component branch January 16, 2023 19:54
@nahueespinosa
Copy link
Member

Related to #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@glpuga glpuga

Labels
enhancement New feature or request ros Related to ROS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glpuga @nahueespinosa