Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch params to select localization node #83

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

nahueespinosa
Copy link
Member

This patch updates the rosbag launch example to take a command prefix and a localization node as parameters. This way we can use it to get CPU and memory usage reports and we can also compare against nav2_amcl.

The command to launch and get performance metrics from our implementation is:

ros2 launch beluga_example example_rosbag_launch.py prefix:='timem --'

For nav2_amcl:

ros2 launch beluga_example example_rosbag_launch.py package:=nav2_amcl node:=amcl prefix:='timem --'

Related to #35.

This patch updates the rosbag launch example to take a command prefix and a localization node as parameters. This way we can use it to get CPU and memory usage reports and we can also compare against nav2_amcl.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added enhancement New feature or request ros Related to ROS labels Jan 24, 2023
@nahueespinosa nahueespinosa self-assigned this Jan 24, 2023
Copy link
Collaborator

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nahueespinosa nahueespinosa merged commit 17e95ba into main Jan 24, 2023
@nahueespinosa nahueespinosa deleted the nahuel/launch_params branch January 24, 2023 16:27
@nahueespinosa nahueespinosa changed the title Update launch file to support command prefix Add launch params to select localization node Jan 24, 2023
@nahueespinosa nahueespinosa added the python Related to Python code label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Related to Python code ros Related to ROS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants