Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to unify Return method for LDAP auth #3

Open
El-Virus opened this issue Jun 23, 2023 · 1 comment
Open

Need to unify Return method for LDAP auth #3

El-Virus opened this issue Jun 23, 2023 · 1 comment
Assignees
@El-Virus
Labels
enhancement New feature or request

Comments

@El-Virus
Copy link
Owner

ByteHamster said:
Instead of sometimes returning false and sometimes setting $success to false, I think it would be more clean to always use return statements. Maybe together with a try {...} finally { ldap_close() } block?
@El-Virus El-Virus added the enhancement New feature or request label Jun 23, 2023
@El-Virus El-Virus self-assigned this Jun 23, 2023
@El-Virus
Copy link
Owner Author

Note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@El-Virus El-Virus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@El-Virus