-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Allow settings attributes on <ile-root>
#150
Comments
Marking it as an enhancement because Would like to get some proposals for how to differentiate attributes for the wrapper and the inner component. I'm leaning towards reserving the <div class="parent">
<MyComponent client:load ile-class="child" class="grandchild">
</div> would result in: <div class="parent">
<ile-root id="ile-1" class="child">
<div class="grandchild">Hello World!</div>
</ile-root>
</div> |
<ile-root>
<ile-root>
Maybe allow people to use Maybe? |
It seems that adding |
After considering the usages in existing sites, and assessing the trade-offs in implementation complexity, I decided to try the following approach. The current behavior will be to apply the |
Is your feature request related to a problem? Please describe.
I tried to make a client-side hydrated
div
that grows to the size of its parent.The following CSS is applied to it.
But the markup that is generated has the
<ile-root>
component in the middle of the tree which prevents the styles from working.Describe the solution you'd like
It should be possible to apply some styles to the
ile-root
element. A hacky approach would be to support attributes likeiles-class
oriles-style
that applies to the<ile-root>
element instead of being passed down.The above template should produce the below markup.
Describe alternatives you've considered
Avoiding the use of styles based parent-child relationship works for now.
The text was updated successfully, but these errors were encountered: