Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When no search results are returned, the aggregations are also missing #576

Open
shochdoerfer opened this issue Oct 26, 2023 · 0 comments
Open

Comments

@shochdoerfer
Copy link
Contributor

While developing the adapter for Sylius, I ran into an issue: When using the aggregations/filters and setting them to a combination that does not return results from Gally, the aggregations are missing in the response, and thus, the list of filters for the storefront cannot be built again. That leaves the customer with an empty search result list and no way to recover.

Obviously, it makes sense why this happens, but it is problematic for the user. The only "solution" to fix this that came to my mind would be to run the Elasticsearch query again but without the filters, build the aggregations as normal, and return them with the empty response. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant