Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve range handling for price aggregation #585

Open
shochdoerfer opened this issue Dec 19, 2023 · 0 comments
Open

Improve range handling for price aggregation #585

shochdoerfer opened this issue Dec 19, 2023 · 0 comments

Comments

@shochdoerfer
Copy link
Contributor

Given I have a product with a price of 68.13 synced to Gally, the Gally response for the price aggregation filter will contain 68 as the maximum value. When sending the max value of 68 back to Gally, the product with the 68.13 price gets filtered out (since I am using a "lte" filter with 68).

My current "fix" in the Sylius connector is to add 1 to the max value sent by Gally. But I feel this is something that should not be the responsibility of the connector, but rather Gally should round up or add 1 to the max value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant