Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Commitlint to verify commit messages #2

Open
sunstorymvp opened this issue Nov 10, 2017 · 2 comments
Open

Adopt Commitlint to verify commit messages #2

sunstorymvp opened this issue Nov 10, 2017 · 2 comments

Comments

@sunstorymvp
Copy link

https://github.com/marionebl/commitlint

  • pros:
    • more strict way to manage commit messages
    • could be configured both locally and on CI
    • shareable configuration across projects (not global)
    • standard linting config format (eslint, stylelint etc.)
  • cons:
    • should be added to every Elateral project to be consistent
@sunstorymvp
Copy link
Author

sunstorymvp commented Nov 10, 2017

cc @hhastekin-elateral @sergey-trotsyuk @1-rswe @robinduckett @AlexKiryanau @AlexVitkouski @jdelibas

@jdelibas
Copy link
Contributor

I did consider this and it would be nice down the line, but needed something quick we could all work with for now.

But would be very valuable and remove a lot of errors we may introduce.
Also we can go a few steps further and close tickets in TP based off the id and stuff at CI level.
We can also generate sensible changelogs automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants