Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add markdown content route config #115

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Conversation

noxasch
Copy link
Contributor

@noxasch noxasch commented Jun 13, 2021

  • update index.spec.js

  • reduce markdown input to bare minimum

address #61

- update index.spec.js

- reduce markdown input to bare minimum

address Elderjs#61
@noxasch
Copy link
Contributor Author

noxasch commented Jun 14, 2021

As i have been testing while using it, build will work just fine. However rollup will not watch the changes during dev. Do we have any interface to include those folder into chokidar config inside the elderjs rollupPlugin.ts ?

If it's there, that'll be cool. If there isn't that's okay too. I will make sure to update the readme to mention that.

@nickreese
Copy link
Contributor

@noxasch Currently no interface on chokidar but it does watch the ./src/.

I'm open to sending an array of files to the watcher once we get a stable interface.

On the next branch we have a pretty stable esbuild setup but on release it will still be tagged as experimental as we're evaluating vite to see if we can get an easy with with HMR with the help of a few people in the Svelte community.

@nickreese
Copy link
Contributor

@noxasch Looks great to me. Elegant and clean, I think an example of how to use it in the readme.md would be helpful.

Great job as always.

@noxasch
Copy link
Contributor Author

noxasch commented Jun 15, 2021

@nickreese done with the docs.

@noxasch Currently no interface on chokidar but it does watch the ./src/.

I'm open to sending an array of files to the watcher once we get a stable interface.

On the next branch we have a pretty stable esbuild setup but on release it will still be tagged as experimental as we're evaluating vite to see if we can get an easy with with HMR with the help of a few people in the Svelte community.

That'll be great. Btw should I make a new PR for the plugin-images which address a bug that happen when we set image src in the config to be the same path as contents in the plugin-markdown, the plugin will throw elderjs-plugin-images: no manifest found at <PATH>. This will also fix #67 at the same time.

@nickreese
Copy link
Contributor

@noxasch That would be awesome. I'll get this one merged and shipped. Looks great. You're a rockstar.

@nickreese nickreese merged commit 210e8e9 into Elderjs:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants