Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK audit] Recommendation: Hex decoder silently ignores last character of an odd-length string #1456

Open
HonzaR opened this issue Apr 23, 2024 · 0 comments

Comments

@HonzaR
Copy link
Collaborator

HonzaR commented Apr 23, 2024

Is your feature request related to a problem? Please describe.

The following hex decoder in BlockExt.kt will silently ignore the last character in an odd-length hex string, because of the integer division len / 2. It should instead throw an exception for odd-length strings.

Screenshot 2024-04-23 at 14 02 26

Describe the solution you'd like

Alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant