Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK audit] Recommendation: Comparing error message strings is fragile #1457

Open
HonzaR opened this issue Apr 23, 2024 · 0 comments
Open

[SDK audit] Recommendation: Comparing error message strings is fragile #1457

HonzaR opened this issue Apr 23, 2024 · 0 comments

Comments

@HonzaR
Copy link
Collaborator

HonzaR commented Apr 23, 2024

Is your feature request related to a problem? Please describe.

The SDK determines which type of error occurred within librustzcash by comparing the error message string:

Screenshot 2024-04-23 at 14 03 41

Describe the solution you'd like

This is fragile, since if the error messages are changed in librustzcash, this code will break. In librustzcash, these error messages are defined in zcash client backend/src/scanning.rs.
This could be made less fragile by using integer codes for errors, exposing a method for determining the error type in the FFI, or by at least adding a comment to librustzcash warning against changing the error message strings.

Alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant