Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK audit] Recommendation: Use SHA256 instead of SHA1 for parameter file integrity checks #1459

Open
HonzaR opened this issue Apr 23, 2024 · 0 comments

Comments

@HonzaR
Copy link
Collaborator

HonzaR commented Apr 23, 2024

Is your feature request related to a problem? Please describe.

The SDK uses the SHA1 to check that the correct parameter files have been downloaded. SHA1 is vulnerable to collision attacks, so it should be replaced with SHA256 or another secure hash function.
This is not a security risk, since SHA1 is still secure against second-preimage attacks (which is what would be needed to get the wallet to accept bad parameter files), nevertheless SHA1 should still be avoided.

Describe the solution you'd like

Check and refactor File.getSha1Hash(): String API

Alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant