Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine controlled and uncontrolled signal check into one function #65

Open
ElectricityMachine opened this issue Apr 18, 2024 · 0 comments
Assignees
Labels
feature request New feature or request
Milestone

Comments

@ElectricityMachine
Copy link
Owner

If colors are found, return True like normal. If colors are not found, but the white dots of an uncontrolled box are found, return True. If nothing is found, return False. This has the benefit of using one less capture and potentially speeding up uncontrolled signal functions, such as C and F for camera and sidemenu, since it doesn't have to repeat the screengrab. We can return an enum, maybe, for what type of signal box we've found (SIGNAL_DIALOG_CONTROLLED, SIGNAL_DIALOG_UNCONTROLLED, None).

Essentially, it's a better version of 9c135fa.

Once implemented, closes #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant