Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizardry's banner patterns cannot be applied to shields/missing shield texture #684

Open
StarWithRockDots opened this issue Jul 1, 2021 · 2 comments
Labels
bug Anything that isn't working how it's supposed to enhancement This is a suggestion for improving the mod/code

Comments

@StarWithRockDots
Copy link

Minecraft version: 1.12.2
Wizardry version: 4.3.4
Environment: All (client-side issue)

Issue details: Whenever a banner featuring one of Wizardry's banner patterns is applied to a shield, the entire shield turns blank white. This is simply because Wizardry's banner patterns have no corresponding shield textures in the files.

I actually did manage to fix the issue by making the missing textures myself and adding them in via resource pack. I was actually thinking of doing a pull request or something here with the textures I made, but I am unfortunately still officially a GitHub noob and just ended up getting lost and overwhelmed. 😅 If it's alright, and if you're interested, I'd be glad to upload the files/resource pack in this issue instead--both so that you can get the textures from it, and also so that other players can use the pack as a workaround until the issue is fixed. Sorry about my awkwardness

@StarWithRockDots StarWithRockDots added the bug Anything that isn't working how it's supposed to label Jul 1, 2021
@WinDanesz
Copy link
Collaborator

PRs are welcome by Electroblob, you can upload the file here, or join the discord and there
https://discord.gg/9T5KUjg
There we can also help creating the PR yourself if you are interested

@StarWithRockDots
Copy link
Author

StarWithRockDots commented Jul 4, 2021

Thanks for the helpful offer! Come to think of it though, I should probably just upload the files here, since I haven't actually posted any example pics of the textures yet. I wouldn't want to go wasting anyone's time if my textures aren't a good fit

Speaking of, here's a pic of the textures in question--
WizardryShields

And here are the actual files (contained in a resource pack as mentioned previously, for the convenience of any other players who want to use them in the meantime too)--
WizardryShieldPatterns_ResourcePack.zip

PS: Sorry for the delay ^^;

@WinDanesz WinDanesz added the enhancement This is a suggestion for improving the mod/code label Feb 5, 2022
@WinDanesz WinDanesz added this to In Progress in Tasks for 4.3.6 Feb 5, 2022
@WinDanesz WinDanesz moved this from In Progress to To Do in Tasks for 4.3.6 Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Anything that isn't working how it's supposed to enhancement This is a suggestion for improving the mod/code
Projects
Development

No branches or pull requests

2 participants